Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(devops): Use correct name for cd-build-zcash-params.yml #7797

Closed
wants to merge 2 commits into from
Closed

change(devops): Use correct name for cd-build-zcash-params.yml #7797

wants to merge 2 commits into from

Conversation

teor2345
Copy link
Collaborator

Motivation

This isn't a reusable workflow, so it should either start with ci or cd. Since it is only run on the main branch, cd seems better.

Review

This is a low priority cleanup.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 22, 2023
@teor2345 teor2345 self-assigned this Oct 22, 2023
@teor2345 teor2345 requested a review from a team as a code owner October 22, 2023 21:53
@teor2345 teor2345 requested review from upbqdn and removed request for a team October 22, 2023 21:53
@teor2345
Copy link
Collaborator Author

This workflow will be deleted by PR #7613 or the PR after it, so changing its name will just cause merge conflicts.

@teor2345 teor2345 closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teor2345