Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos #7857

Closed
wants to merge 1 commit into from
Closed

chore: fix typos #7857

wants to merge 1 commit into from

Conversation

vuittont60
Copy link
Contributor

fix some typos

@vuittont60 vuittont60 requested review from a team as code owners October 27, 2023 03:39
@vuittont60 vuittont60 requested review from oxarbitrage and removed request for a team October 27, 2023 03:39
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 27, 2023
teor2345
teor2345 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@oxarbitrage oxarbitrage mentioned this pull request Oct 27, 2023
Merged
@oxarbitrage
Copy link
Contributor

Thanks @vuittont60 , i have to close this one and replace it with #7862, which is the same code but from a branch inside the foundation repo so we can merge.

@vuittont60
Copy link
Contributor Author

That's all right. Thank you.

@teor2345
Copy link
Collaborator

Failed due to #4529.

@mpguerra
Copy link
Contributor

@gustavovalverde I thought we would be able to see a way to allow some jobs to run here?

@teor2345
Copy link
Collaborator

@gustavovalverde I thought we would be able to see a way to allow some jobs to run here?

I already clicked the Approve and run button, it only needs be clicked once for every PR change.

After I clicked the button, most jobs worked, but the list I posted in #4529 didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/network-reviewers

Assignees
No one assigned
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vuittont60 @oxarbitrage @teor2345 @mpguerra