Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ci): Delete unused cached state patch job #7901

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

teor2345
Copy link
Collaborator

@teor2345 teor2345 commented Nov 3, 2023

Motivation

The cached state isn't used for Docker unit tests, so its patch job isn't needed.

There is no corresponding job in the Docker unit tests:
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/ci-unit-tests-docker.yml#L78

The job and patch are correctly configured in the Docker GCP integration tests:
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/ci-integration-tests-gcp.yml#L105
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/ci-integration-tests-gcp.patch.yml#L30

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Not a significant change.

If a checkbox isn't relevant to the PR, mark it as done.

Solution

Delete the unused duplicate patch job.

Testing

If CI passes we're fine here.

Review

This is a low priority cleanup. It can merge at any time during the release process, because it doesn't need to go in the changelog.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Nov 3, 2023
@teor2345 teor2345 self-assigned this Nov 3, 2023
@teor2345 teor2345 requested a review from a team as a code owner November 3, 2023 01:26
@teor2345 teor2345 requested review from upbqdn and removed request for a team November 3, 2023 01:26
@teor2345
Copy link
Collaborator Author

teor2345 commented Nov 5, 2023

This PR can merge at any time during the release process, because it doesn't need to go in the changelog.

Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mergify bot added a commit that referenced this pull request Nov 6, 2023
@mergify mergify bot merged commit baa283c into main Nov 6, 2023
69 checks passed
@mergify mergify bot deleted the unused-ci-patch branch November 6, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants