cleanup(ci): Delete unused cached state patch job #7901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The cached state isn't used for Docker unit tests, so its patch job isn't needed.
There is no corresponding job in the Docker unit tests:
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/ci-unit-tests-docker.yml#L78
The job and patch are correctly configured in the Docker GCP integration tests:
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/ci-integration-tests-gcp.yml#L105
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/ci-integration-tests-gcp.patch.yml#L30
PR Author Checklist
Check before marking the PR as ready for review:
Not a significant change.
If a checkbox isn't relevant to the PR, mark it as done.
Solution
Delete the unused duplicate patch job.
Testing
If CI passes we're fine here.
Review
This is a low priority cleanup. It can merge at any time during the release process, because it doesn't need to go in the changelog.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.