Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(chain): Remove Copy trait impl from Network #8354

Merged
merged 49 commits into from
Mar 19, 2024
Merged

change(chain): Remove Copy trait impl from Network #8354

merged 49 commits into from
Mar 19, 2024

Commits on Mar 15, 2024

  1. removed derive copy from network, address and ledgerstate

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    78d799d View commit details
    Browse the repository at this point in the history

  2. changed is_max_block_time_enforced to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    abe86ad View commit details
    Browse the repository at this point in the history

  3. changed NetworkUpgrade::Current to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2586f10 View commit details
    Browse the repository at this point in the history

  4. changed NetworkUpgrade::Next to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b088c07 View commit details
    Browse the repository at this point in the history

  5. changed NetworkUpgrade::IsActivationHeight to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d555f5b View commit details
    Browse the repository at this point in the history

  6. changed NetworkUpgrade::TargetSpacingForHeight to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9d507bd View commit details
    Browse the repository at this point in the history

  7. changed NetworkUpgrade::TargetSpacings to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d6a03ae View commit details
    Browse the repository at this point in the history

  8. changed NetworkUpgrade::MinimumDifficultySpacing_forHeight to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8eb42ff View commit details
    Browse the repository at this point in the history

  9. changed NetworkUpgrade::IsTestnetMinDifficultyBlock to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c04c94f View commit details
    Browse the repository at this point in the history

  10. changed NetworkUpgrade::AveragingWindowTimespanForHeight to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    bdf80c1 View commit details
    Browse the repository at this point in the history

  11. changed NetworkUpgrade::ActivationHeight to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    30c4cbe View commit details
    Browse the repository at this point in the history

  12. changed sapling_activation_height to accept ref

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0e23b5d View commit details
    Browse the repository at this point in the history

  13. fixed lifetime for target_spacings

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    05c2a88 View commit details
    Browse the repository at this point in the history

  14. fixed sapling_activation_height

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    984d106 View commit details
    Browse the repository at this point in the history

  15. changed transaction_to_fake_v5 and fake_v5_transactions_for_network t… 

    …o accept ref to network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3d63f83 View commit details
    Browse the repository at this point in the history

  16. changed Input::vec_strategy to accept ref to network

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6af7425 View commit details
    Browse the repository at this point in the history

  17. changed functions in zebra-chain/src/primitives/zcash_history.rs to a… 

    …ccept ref to network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f3ce942 View commit details
    Browse the repository at this point in the history

  18. changed functions in zebra-chain/src/history_tree.rs to accept ref to… 

    … network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d985e87 View commit details
    Browse the repository at this point in the history

  19. changed functions in zebra-chain/src/history_tree.rs to accept ref to… 

    … network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4ba2241 View commit details
    Browse the repository at this point in the history

  20. changed functions in zebra-chain/src/primitives/address.rs to accept … 

    …ref to network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c656b2b View commit details
    Browse the repository at this point in the history

  21. changed functions in zebra-chain/src/primitives/viewing_key* to accep… 

    …t ref to network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    42de8e2 View commit details
    Browse the repository at this point in the history

  22. changed functions in zebra-chain/src/transparent/address.rs to accept… 

    … ref to network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    44a49a6 View commit details
    Browse the repository at this point in the history

  23. changed functions in zebra-chain/src/primitives/zcash_primitives.rs t… 

    …o accept ref to network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    eccc589 View commit details
    Browse the repository at this point in the history

  24. changed functions in zebra-chain/src/primitives/zcash_note_encryption… 

    ….rs to accept ref to network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    59fb9e6 View commit details
    Browse the repository at this point in the history

  25. changed functions in zebra-chain/src/primitives/history_tree* to acce… 

    …pt ref to network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    e42c6fa View commit details
    Browse the repository at this point in the history

  26. changed functions in zebra-chain/src/block* to accept ref to network

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fdf8b1c View commit details
    Browse the repository at this point in the history

  27. fixed errors in zebra-chain::parameters::network

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    322fbf9 View commit details
    Browse the repository at this point in the history

  28. fixed errors in zebra-chain::parameters::network

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    51f8c51 View commit details
    Browse the repository at this point in the history

  29. fixed errors in zebra-chain

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b865166 View commit details
    Browse the repository at this point in the history

  30. changed NonEmptyHistoryTree and InnerHistoryTree to hold value instea… 

    …d of ref
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d61639d View commit details
    Browse the repository at this point in the history

  31. changed NonEmptyHistoryTree and InnerHistoryTree to hold value instea… 

    …d of ref
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    72540ec View commit details
    Browse the repository at this point in the history

  32. fixed errors in zebra-chain/src/block/arbitrary.rs

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    5be0d86 View commit details
    Browse the repository at this point in the history

  33. finished fixing errors in zebra-chain - all crate tests pass

    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6906634 View commit details
    Browse the repository at this point in the history

  34. changed functions in zebra-state::service::finalized_state to accept … 

    …&Network
    @idky137
    idky137 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    313598b View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. changed functions in zebra-state::service::non_finalized_state to acc… 

    …ept &Network
    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7c1ab87 View commit details
    Browse the repository at this point in the history

  2. zebra-state tests run but fail with overflow error

    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a24612e View commit details
    Browse the repository at this point in the history

  3. zebra-state tests all pass

    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7e539ae View commit details
    Browse the repository at this point in the history

  4. converted zebra-network -- all crate tests pass

    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    08ed2f3 View commit details
    Browse the repository at this point in the history

  5. applied all requested changes from review

    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    08ab2ea View commit details
    Browse the repository at this point in the history

  6. converted zebra-consensus -- all crate tests pass

    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    04a9301 View commit details
    Browse the repository at this point in the history

  7. converted zebra-scan -- all crate tests pass

    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    fed20b2 View commit details
    Browse the repository at this point in the history

  8. converted zebra-rpc -- all crate tests pass

    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    676b3ad View commit details
    Browse the repository at this point in the history

  9. converted zebra-grpc -- all crate tests pass

    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3063bca View commit details
    Browse the repository at this point in the history

  10. converted zebrad -- all crate tests pass

    @idky137
    idky137 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    64c6384 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. applied all requested changes from review

    @idky137
    idky137 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    31ea135 View commit details
    Browse the repository at this point in the history

  2. fixed all clippy errors

    @idky137
    idky137 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    17ea497 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'ecc/main' into remove_derive_copy_from_… 

    …network
    @idky137
    idky137 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    06ad700 View commit details
    Browse the repository at this point in the history

  4. fixed build error in zebrad/src/components/mempool/crawler.rs

    @idky137
    idky137 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b09707c View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'ecc/main' into remove_derive_copy_from_… 

    …network
    @idky137
    idky137 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4e81cad View commit details
    Browse the repository at this point in the history