Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(consensus): Add slow_start_{interval/shift} fields to testnet::Parameters #8477

Merged
merged 2 commits into from
May 8, 2024

Apply suggestions from code review

ac4b587
Select commit
Loading
Failed to load commit list.
Merged

add(consensus): Add slow_start_{interval/shift} fields to testnet::Parameters #8477

Apply suggestions from code review
ac4b587
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded May 8, 2024 in 0s

The pull request embarked with main (15e1096) will be merged soon

Required conditions for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • #review-threads-unresolved=0 [🛡 GitHub branch protection]
  • base=main
  • any of [🛡 GitHub branch protection]:
    • check-success=Rustfmt
    • check-neutral=Rustfmt
    • check-skipped=Rustfmt
  • any of [🛡 GitHub branch protection]:
    • check-success=mergefreeze
    • check-neutral=mergefreeze
    • check-skipped=mergefreeze
  • any of [🛡 GitHub branch protection]:
    • check-success=Clippy
    • check-neutral=Clippy
    • check-skipped=Clippy
  • any of [🛡 GitHub branch protection]:
    • check-success=Test with fake activation heights
    • check-neutral=Test with fake activation heights
    • check-skipped=Test with fake activation heights
  • any of [🛡 GitHub branch protection]:
    • check-success=Test all
    • check-neutral=Test all
    • check-skipped=Test all
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml bans
    • check-neutral=Check deny.toml bans
    • check-skipped=Check deny.toml bans
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml bans --all-features
    • check-neutral=Check deny.toml bans --all-features
    • check-skipped=Check deny.toml bans --all-features
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml sources
    • check-neutral=Check deny.toml sources
    • check-skipped=Check deny.toml sources
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml sources --all-features
    • check-neutral=Check deny.toml sources --all-features
    • check-skipped=Check deny.toml sources --all-features
  • any of [🛡 GitHub branch protection]:
    • check-success=Check Cargo.lock is up to date
    • check-neutral=Check Cargo.lock is up to date
    • check-skipped=Check Cargo.lock is up to date
  • any of [🛡 GitHub branch protection]:
    • check-success=Install zebrad from lockfile without cache on ubuntu-latest
    • check-neutral=Install zebrad from lockfile without cache on ubuntu-latest
    • check-skipped=Install zebrad from lockfile without cache on ubuntu-latest
  • any of [🛡 GitHub branch protection]:
    • check-success=Test checkpoint sync from empty state
    • check-neutral=Test checkpoint sync from empty state
    • check-skipped=Test checkpoint sync from empty state
  • any of [🛡 GitHub branch protection]:
    • check-skipped=Zebra checkpoint update / Run sync-past-checkpoint test
    • check-neutral=Zebra checkpoint update / Run sync-past-checkpoint test
    • check-success=Zebra checkpoint update / Run sync-past-checkpoint test
  • any of [🛡 GitHub branch protection]:
    • check-skipped=Zebra tip JSON-RPC / Run fully-synced-rpc test
    • check-neutral=Zebra tip JSON-RPC / Run fully-synced-rpc test
    • check-success=Zebra tip JSON-RPC / Run fully-synced-rpc test
  • any of [🛡 GitHub branch protection]:
    • check-success=Build tower-fallback crate
    • check-neutral=Build tower-fallback crate
    • check-skipped=Build tower-fallback crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-chain crate
    • check-neutral=Build zebra-chain crate
    • check-skipped=Build zebra-chain crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-consensus crate
    • check-neutral=Build zebra-consensus crate
    • check-skipped=Build zebra-consensus crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-network crate
    • check-neutral=Build zebra-network crate
    • check-skipped=Build zebra-network crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-node-services crate
    • check-neutral=Build zebra-node-services crate
    • check-skipped=Build zebra-node-services crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-rpc crate
    • check-neutral=Build zebra-rpc crate
    • check-skipped=Build zebra-rpc crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-script crate
    • check-neutral=Build zebra-script crate
    • check-skipped=Build zebra-script crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-state crate
    • check-neutral=Build zebra-state crate
    • check-skipped=Build zebra-state crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-test crate
    • check-neutral=Build zebra-test crate
    • check-skipped=Build zebra-test crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-utils crate
    • check-neutral=Build zebra-utils crate
    • check-skipped=Build zebra-utils crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebrad crate
    • check-neutral=Build zebrad crate
    • check-skipped=Build zebrad crate
  • any of [🛡 GitHub branch protection]:
    • check-skipped=Zebra tip update / Run update-to-tip test
    • check-neutral=Zebra tip update / Run update-to-tip test
    • check-success=Zebra tip update / Run update-to-tip test
  • any of [🛡 GitHub branch protection]:
    • check-success=Test beta on ubuntu-latest
    • check-neutral=Test beta on ubuntu-latest
    • check-skipped=Test beta on ubuntu-latest
  • any of [🛡 GitHub branch protection]:
    • check-success=Test stable on ubuntu-latest
    • check-neutral=Test stable on ubuntu-latest
    • check-skipped=Test stable on ubuntu-latest
  • any of [🛡 GitHub branch protection]:
    • check-skipped=Build CI Docker / Build images
    • check-neutral=Build CI Docker / Build images
    • check-success=Build CI Docker / Build images
  • any of [🛡 GitHub branch protection]:
    • check-skipped=submit block / Run submit-block test
    • check-neutral=submit block / Run submit-block test
    • check-success=submit block / Run submit-block test
  • any of [🛡 GitHub branch protection]:
    • check-skipped=get block template / Run get-block-template test
    • check-neutral=get block template / Run get-block-template test
    • check-success=get block template / Run get-block-template test
  • any of [🛡 GitHub branch protection]:
    • check-success=Check for unused dependencies
    • check-neutral=Check for unused dependencies
    • check-skipped=Check for unused dependencies
  • any of [🛡 GitHub branch protection]:
    • check-skipped=Check if cached state disks exist for Mainnet / Check if cached state disks exist
    • check-neutral=Check if cached state disks exist for Mainnet / Check if cached state disks exist
    • check-success=Check if cached state disks exist for Mainnet / Check if cached state disks exist
  • any of [🛡 GitHub branch protection]:
    • check-success=Check crates matrix
    • check-neutral=Check crates matrix
    • check-skipped=Check crates matrix
  • any of [🛡 GitHub branch protection]:
    • check-success=Generate crates matrix
    • check-neutral=Generate crates matrix
    • check-skipped=Generate crates matrix
  • any of [🛡 GitHub branch protection]:
    • check-success=Build tower-batch-control crate
    • check-neutral=Build tower-batch-control crate
    • check-skipped=Build tower-batch-control crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml bans --features default-release-binaries
    • check-neutral=Check deny.toml bans --features default-release-binaries
    • check-skipped=Check deny.toml bans --features default-release-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml sources --features default-release-binaries
    • check-neutral=Check deny.toml sources --features default-release-binaries
    • check-skipped=Check deny.toml sources --features default-release-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=Check crate release dry run
    • check-neutral=Check crate release dry run
    • check-skipped=Check crate release dry run
  • any of [🛡 GitHub branch protection]:
    • check-skipped=Build CD Docker / Build images
    • check-neutral=Build CD Docker / Build images
    • check-success=Build CD Docker / Build images
  • any of [🛡 GitHub branch protection]:
    • check-success=Test integration with lightwalletd
    • check-neutral=Test integration with lightwalletd
    • check-skipped=Test integration with lightwalletd
  • any of [🛡 GitHub branch protection]:
    • check-skipped=lightwalletd GRPC tests / Run lwd-grpc-wallet test
    • check-neutral=lightwalletd GRPC tests / Run lwd-grpc-wallet test
    • check-success=lightwalletd GRPC tests / Run lwd-grpc-wallet test
  • any of [🛡 GitHub branch protection]:
    • check-skipped=lightwalletd tip send / Run lwd-send-transactions test
    • check-neutral=lightwalletd tip send / Run lwd-send-transactions test
    • check-success=lightwalletd tip send / Run lwd-send-transactions test
  • any of [🛡 GitHub branch protection]:
    • check-success=Build and Deploy Zebra Book Docs
    • check-neutral=Build and Deploy Zebra Book Docs
    • check-skipped=Build and Deploy Zebra Book Docs
  • any of [🛡 GitHub branch protection]:
    • check-success=Build and Deploy Zebra Internal Docs
    • check-neutral=Build and Deploy Zebra Internal Docs
    • check-skipped=Build and Deploy Zebra Internal Docs
  • any of [🛡 GitHub branch protection]:
    • check-skipped=lightwalletd tip update / Run lwd-update-sync test
    • check-neutral=lightwalletd tip update / Run lwd-update-sync test
    • check-success=lightwalletd tip update / Run lwd-update-sync test
  • any of [🛡 GitHub branch protection]:
    • check-skipped=Generate checkpoints mainnet / Run checkpoints-mainnet test
    • check-neutral=Generate checkpoints mainnet / Run checkpoints-mainnet test
    • check-success=Generate checkpoints mainnet / Run checkpoints-mainnet test
  • any of [🛡 GitHub branch protection]:
    • check-skipped=Test CD custom Docker config file / Test custom-conf in Docker
    • check-neutral=Test CD custom Docker config file / Test custom-conf in Docker
    • check-success=Test CD custom Docker config file / Test custom-conf in Docker
  • any of [🛡 GitHub branch protection]:
    • check-skipped=Test CD default Docker config file / Test default-conf in Docker
    • check-neutral=Test CD default Docker config file / Test default-conf in Docker
    • check-success=Test CD default Docker config file / Test default-conf in Docker
  • any of [🛡 GitHub branch protection]:
    • check-success=Test CI custom Docker config file / Test custom-conf in Docker
    • check-neutral=Test CI custom Docker config file / Test custom-conf in Docker
    • check-skipped=Test CI custom Docker config file / Test custom-conf in Docker
  • any of [🛡 GitHub branch protection]:
    • check-success=Test CI default Docker config file / Test default-conf in Docker
    • check-neutral=Test CI default Docker config file / Test default-conf in Docker
    • check-skipped=Test CI default Docker config file / Test default-conf in Docker
  • any of [🛡 GitHub branch protection]:
    • check-success=Test stable on macos-latest
    • check-neutral=Test stable on macos-latest
    • check-skipped=Test stable on macos-latest
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-scan crate
    • check-neutral=Build zebra-scan crate
    • check-skipped=Build zebra-scan crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Test beta on windows-latest
    • check-neutral=Test beta on windows-latest
    • check-skipped=Test beta on windows-latest
  • any of [🛡 GitHub branch protection]:
    • check-success=Test stable on windows-latest
    • check-neutral=Test stable on windows-latest
    • check-skipped=Test stable on windows-latest

Check-runs and statuses of the embarked pull request #8516:

Build CD Docker / Build images details
Build CI Docker / Build images details
Check if cached state disks exist for Mainnet / Check if cached state disks exist details
Deploy ${{ matrix.network }} nodes details
Deploy single ${{ inputs.network }} instance details
Generate checkpoints mainnet / Create ${{ inputs.test_id }} cached state image details
Generate checkpoints mainnet / Run checkpoints-mainnet test details
Open or update issues for OS integration failures details
Open or update issues for building crates individually failures details
Open or update issues for main branch failures details
Open or update issues for release crates failures details
Open or update issues for release failures details
Scan starts where left / Run scan-start-where-left test details
Test CD custom Docker config file / Test custom-conf in Docker details
Test CD default Docker config file / Test default-conf in Docker details
Versioning details
Zebra checkpoint details
Zebra checkpoint update / Create ${{ inputs.test_id }} cached state image details
Zebra checkpoint update / Run sync-past-checkpoint test details
Zebra tip details
Zebra tip JSON-RPC / Create ${{ inputs.test_id }} cached state image details
Zebra tip JSON-RPC / Run fully-synced-rpc test details
Zebra tip on testnet details
Zebra tip update / Run update-to-tip test details
actionlint details
get block template / Create ${{ inputs.test_id }} cached state image details
get block template / Run get-block-template test details
lightwalletd GRPC tests / Create ${{ inputs.test_id }} cached state image details
lightwalletd GRPC tests / Run lwd-grpc-wallet test details
lightwalletd tip details
lightwalletd tip / Run lwd-full-sync test details
lightwalletd tip send / Create ${{ inputs.test_id }} cached state image details
lightwalletd tip send / Run lwd-send-transactions test details
lightwalletd tip update / Run lwd-update-sync test details
scan task commands / Create ${{ inputs.test_id }} cached state image details
scan task commands / Run scan-task-commands test details
submit block / Create ${{ inputs.test_id }} cached state image details
submit block / Run submit-block test details
Build and Deploy Zebra Book Docs details
Build and Deploy Zebra Internal Docs details
Build tower-batch-control crate details
Build tower-fallback crate details
Build zebra-chain crate details
Build zebra-consensus crate details
Build zebra-grpc crate details
Build zebra-network crate details
Build zebra-node-services crate details
Build zebra-rpc crate details
Build zebra-scan crate details
Build zebra-script crate details
Build zebra-state crate details
Build zebra-test crate details
Build zebra-utils crate details
Build zebrad crate details
Check Cargo.lock is up to date details
Check crate release dry run details
Check crates matrix details
Check deny.toml bans details
Check deny.toml bans --all-features details
Check deny.toml bans --features default-release-binaries details
Check deny.toml sources details
Check deny.toml sources --all-features details
Check deny.toml sources --features default-release-binaries details
Check for unused dependencies details
Check if cached state disks exist for testnet / Check if cached state disks exist details
Checks changed-files details
Clippy details
Generate checkpoints mainnet / Delete checkpoints-mainnet instance details
Generate checkpoints testnet / Create checkpoints-testnet cached state image details
Generate checkpoints testnet / Delete checkpoints-testnet instance details
Generate checkpoints testnet / Run checkpoints-testnet test details
Generate crates matrix details
Install zebrad from lockfile without cache on ubuntu-latest details
Rustfmt details
Scan starts where left / Create scan-start-where-left cached state image details
Scan starts where left / Delete scan-start-where-left instance details
Test CD testnet Docker config file / Test testnet-conf in Docker details
Test CI custom Docker config file / Test custom-conf in Docker details
Test CI default Docker config file / Test default-conf in Docker details
Test CI testnet Docker config file / Test testnet-conf in Docker details
Test all details
Test beta on ubuntu-latest details
Test beta on windows-latest details
Test checkpoint sync from empty state details
Test integration with lightwalletd details
Test stable on macos-latest details
Test stable on ubuntu-latest details
Test stable on windows-latest details
Test with fake activation heights details
Zebra checkpoint update / Delete sync-past-checkpoint instance details
Zebra tip JSON-RPC / Delete fully-synced-rpc instance details
Zebra tip update / Create update-to-tip cached state image details
Zebra tip update / Delete update-to-tip instance details
codespell details
get block template / Delete get-block-template instance details
lightwalletd GRPC tests / Delete lwd-grpc-wallet instance details
lightwalletd tip send / Delete lwd-send-transactions instance details
lightwalletd tip update / Create lwd-update-sync cached state image details
lightwalletd tip update / Delete lwd-update-sync instance details
mergefreeze Ok to mergedetails
scan task commands / Delete scan-task-commands instance details
submit block / Delete submit-block instance details
update_release_draft details