Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for "feat(regtest): Add regtest halving interval and port test" #8894

Merged

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Sep 26, 2024

This is a suggestion PR for #8888 that:

  • Adds a height_for_halving_index() function to be used for calculating the height for first index on custom Testnets and Regtest (though it's not needed on Regtest as the relevant parameters are not configurable and a hard-coded value is fine).
  • Factors calculating of the number of halvings out of halving_divisor() into num_halvings() for use in tests

@oxarbitrage can review and optionally merge it into their PR.

@arya2 arya2 self-assigned this Sep 26, 2024
@arya2 arya2 requested a review from a team as a code owner September 26, 2024 22:21
@github-actions github-actions bot added C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Sep 26, 2024
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, trying it.

@oxarbitrage oxarbitrage merged commit 120ae74 into regtest-halving-interval Sep 27, 2024
68 of 84 checks passed
@oxarbitrage oxarbitrage deleted the suggestion-for-regtest-halving-interval branch September 27, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants