Tools: Add Activity Export Feature #2785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamkmr04
force-pushed
the
shubham/export-csv-in-tools
branch
3 times, most recently
from
9732aea to
69b405f
Compare
kaloudis
reviewed
Feb 7, 2025
views/ActivityExportOptions.tsx
Outdated
| { label: 'Amount (sat)', value: 'getAmount' }, | ||
| { label: 'Total Fees (sat)', value: 'getFee' }, | ||
| { label: 'Note', value: 'getNote' }, | ||
| { label: 'Timestamp', value: 'getDate' } |
There was a problem hiding this comment.
instead of repeating all these fields from the component on the Activity view, could we possible great this off into a utility file of sorts?
There was a problem hiding this comment.
Yes, sure will do that
There was a problem hiding this comment.
pushed some changes to shift those functionlity to a utils file
shubhamkmr04
force-pushed
the
shubham/export-csv-in-tools
branch
from
25dd28a to
fde74a2
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #2742