Remove vector in definition of DegreeMatrix
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbaldu
changed the title
DegreeMatrixDegreeMatrix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 97.88% 97.88% -0.01%
==========================================
Files 87 87
Lines 10085 10084 -1
Branches 670 670
==========================================
- Hits 9872 9871 -1
Misses 213 213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZigRazor
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #454 I noticed that we define the
DegreeMatrixby placing the degree value for each node inside a vector. This seems a bit excessive, since it can only be a single unsigned integer, and it makes it a bit more verbose to use as well. I redefined it and updated the getter.@ZigRazor @nolankramer let me know if you agree :)