A few build fixes #1254
Merged
A few build fixes #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(fix) A tiny bit more documentation (feat) respect VCPKG_ALWAYS_INSTALL (fix) The protobuf library now appears to want curried arguments.
JamesHinshelwood
approved these changes
Jun 11, 2024
JamesHinshelwood
requested changes
Jun 11, 2024
There was a problem hiding this comment.
CI is using a different version of the pbrt dependency that doesn't want its arguments curried:
#27 311.1 File "src/eval/Ipcmessage_pb.ml", line 114, characters 4-23:
#27 311.1 114 | Pbrt.Encoder.nested encode_proto_scilla_val x encoder
#27 311.1 ^^^^^^^^^^^^^^^^^^^
#27 311.1 Error: This function has type
#27 311.1 (Pbrt.Encoder.t -> unit) -> Pbrt.Encoder.t -> unit
#27 311.1 It is applied to too many arguments; maybe you forgot a `;'.
JamesHinshelwood
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fix) Add emacs backups to .gitignore
(fix) A tiny bit more documentation
(feat) respect VCPKG_ALWAYS_INSTALL
(fix) The protobuf library now appears to want curried arguments.
Closes #1253