Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create NewView on startup and error log proposal failures #2281

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

86667
Copy link
Contributor

@86667 86667 commented Feb 3, 2025

No description provided.

@86667 86667 changed the title fix: create Newview on startup and error log proposal failures fix: create NewView on startup and error log proposal failures Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

🐰 Bencher Report

Branchlog_proposal_execution_failures
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
full-blocks-erc20-transfers/full-blocks-erc20-transfers📈 view plot
🚷 view threshold
1,270.30
(+3.57%)
1,620.26
(78.40%)
full-blocks-evm-transfers/full-blocks-evm-transfers📈 view plot
🚷 view threshold
450.66
(-6.84%)
690.89
(65.23%)
full-blocks-zil-transfers/full-blocks-zil-transfers📈 view plot
🚷 view threshold
3,381.20
(-13.76%)
5,132.19
(65.88%)
process-empty/process-empty📈 view plot
🚷 view threshold
10.28
(+12.10%)
11.54
(89.07%)
🐰 View full continuous benchmarking report in Bencher

Copy link
Contributor

@DrZoltanFazekas DrZoltanFazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced we should send a NewView on startup - let's discuss here or on a call before merging this...

zilliqa/src/consensus.rs Outdated Show resolved Hide resolved
@86667 86667 enabled auto-merge February 7, 2025 11:22
@DrZoltanFazekas DrZoltanFazekas self-requested a review February 7, 2025 11:23
@86667 86667 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit e9f92c4 Feb 7, 2025
6 checks passed
@86667 86667 deleted the log_proposal_execution_failures branch February 7, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants