Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up contract upgrade config #2443

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

86667
Copy link
Contributor

@86667 86667 commented Mar 4, 2025

No description provided.

@86667 86667 requested a review from JamesHinshelwood March 4, 2025 11:15
Copy link
Contributor

github-actions bot commented Mar 4, 2025

🐰 Bencher Report

Branchcontract_upgrades_config
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
full-blocks-erc20-transfers/full-blocks-erc20-transfers📈 view plot
🚷 view threshold
1,331.70 ms
(+22.64%)Baseline: 1,085.87 ms
1,436.94 ms
(92.68%)
full-blocks-evm-transfers/full-blocks-evm-transfers📈 view plot
🚷 view threshold
461.55 ms
(+13.74%)Baseline: 405.80 ms
490.72 ms
(94.06%)
full-blocks-zil-transfers/full-blocks-zil-transfers📈 view plot
🚷 view threshold
4,175.50 ms
(+2.21%)Baseline: 4,085.17 ms
5,670.15 ms
(73.64%)
process-empty/process-empty📈 view plot
🚷 view threshold
10.43 ms
(+4.40%)Baseline: 9.99 ms
10.72 ms
(97.23%)
🐰 View full continuous benchmarking report in Bencher

@86667 86667 force-pushed the contract_upgrades_config branch 2 times, most recently from b6c718f to 5e7e790 Compare March 4, 2025 11:44
@86667 86667 enabled auto-merge March 4, 2025 11:44
Copy link
Contributor

@JamesHinshelwood JamesHinshelwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except to_toml!

@86667 86667 force-pushed the contract_upgrades_config branch from b25a5c3 to aca4335 Compare March 7, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants