Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for handling of lists when creating xml #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flokflok
Copy link

Hey,
the dict_to_dom() method does not correctly handle Python lists. Instead of creating one root element and the sub-elements in it, the root element is repeated for each sub-element.

Example dict:

{
    "a": [
        {
            "b": {
                "id": 1
            }
        },
        {
            "b": {
                "id": 2
            }
        }
    ]
}

Actual result:

<a>
  <b id="1"/>
</a>
<a>
  <b id="2"/>
</a>

Expected result:

<a>
  <b id="1"/>
  <b id="2"/>
</a>

This pull request ought to fix this.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant