Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZRFE-907: Add warning on -a option #103

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

ZRFE-907: Add warning on -a option #103

wants to merge 3 commits into from

Conversation

jholder85638
Copy link
Contributor

@jholder85638 jholder85638 commented Jan 31, 2022 •
edited
Loading

QOL option for zmdialog, add warning on -a

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ronstra-synacor
❌ zmcommand
You have signed the CLA already but the status is still pending? Let us recheck it.

@jholder85638 jholder85638 changed the title Add warning on -j option Add warning on -a option Feb 1, 2022
@jholder85638 jholder85638 changed the title Add warning on -a option ZRFE-907: Add warning on -a option Feb 1, 2022
desouzas
desouzas reviewed Feb 25, 2022
View reviewed changes
Copy link

@desouzas desouzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John there seems to be a bunch of spacing issues in these PRs. Do we need to sort out editor issues?

src/libexec/zmdiaglog Outdated Show resolved Hide resolved
@ronstra-synacor @desouzas
Fix typo
c57b743 
Co-authored-by: Stephan DeSouza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desouzas desouzas desouzas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jholder85638 @CLAassistant @desouzas @zmcommand @ronstra-synacor