ZCS-13340:Add an LDAP attribute to force users not to use username in… #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shubhamCS03
requested review from
dawoodshaikh,
k-kato,
gautamdg,
dasiyogesh,
JayaG,
shrutig0510,
silentsakky,
desouzas,
RakeshAMore,
zimsuchitgupta and
vishnukantjangid
zimsuchitgupta
suggested changes
May 4, 2023
ronstra-synacor
approved these changes
May 4, 2023
swaatiTelus
approved these changes
May 4, 2023
shrutig0510
reviewed
May 5, 2023
shrutig0510
approved these changes
May 5, 2023
zimsuchitgupta
approved these changes
May 5, 2023
silentsakky
reviewed
May 5, 2023
| @@ -10357,4 +10357,9 @@ TODO: delete them permanently from here | |||
| <globalConfigValue>TRUE</globalConfigValue> | |||
| <desc>whether to enable CountObjectsRequest with userAccount/account type on Zimbra Admin Console</desc> | |||
| </attr> | |||
|
|
|||
| <attr id="4098" name="zimbraFeatureAllowUsernameInPassword" type="boolean" cardinality="single" optionalIn="account,cos,domain" flags="accountInfo,accountCosDomainInherited" since="10.1.0"> | |||
There was a problem hiding this comment.
a question related to requirements, should we remove LC value now and add some migration step to move LC value to ldap attribute so customers don't loose data in migration/upgrade
There was a problem hiding this comment.
Saket, under this PR we have just introduced the placeholder for LDAP attribute so it can be shipped to next release. the implementation will be done as a part of ZCS-13218, where in we should take care of the above case you mentioned.
shubhamCS03
force-pushed
the
ZCS-13340
branch
2 times, most recently
from
d186e65
to
80d7a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement of ticket [ZCS-13340]:
Add a new LDAP attribute
zimbraFeatureAllowUsernameInPasswordto restrict/allow the use of usernames in the password when users reset or change their passwords to achieve greater password security.Solution:
One new attributes
zimbraFeatureAllowUsernameInPasswordis added and their setters/getters are generated.