ZBUG-3254: Thunderbird CalDAV Sync Fail #1648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronstra-synacor
force-pushed
the
bugfix/ZBUG-3254/TbirdCalDavSync
branch
from
e18eb71
to
8ea01f7
Compare
ronstra-synacor
requested review from
zimsuchitgupta,
dasiyogesh,
preshitaagrawal and
rcyarrapothu
ronstra-synacor
force-pushed
the
bugfix/ZBUG-3254/TbirdCalDavSync
branch
from
8ea01f7
to
3e384ed
Compare
zimsuchitgupta
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one attempts to Sync a Zimbra CalDAV contacts folder from Thunderbird, nothing happens. The Zimbra server logs the request, but is sending back "empty request body", even though it clearly logs the request just before. Looking into the code, it seems we enforce that the Content-Type of the multipart that contains the request be of some XML type. When I remove that restriction, the synchronization works as expected.
Not sure if this is the right approach. Is it important that we enforce the type? Is it a security issue? Shouldn't we be liberal in what we receive?