Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flex support #29

Merged
merged 5 commits into from
Sep 17, 2024
Merged

flex support #29

merged 5 commits into from
Sep 17, 2024

Conversation

0xPxt
Copy link
Collaborator

@0xPxt 0xPxt commented Sep 10, 2024

Didn't apply make format because it introduces a lot of changes.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@chcmedeiros chcmedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The make cpp_test in CI is falling, let's take the opportunity to change to Hunter.
We have been moving from connan to Hunter.
You can check the latest commits I made into Oasis main here: https://github.com/Zondax/ledger-oasis/commits/main/ to check the needed changes

@chcmedeiros
Copy link
Contributor

PR open in LedgerHQ/ledger-app-database#254 blocking this

@chcmedeiros chcmedeiros self-requested a review September 12, 2024 10:48
@chcmedeiros chcmedeiros self-requested a review September 17, 2024 13:57
@0xPxt 0xPxt merged commit 4d9285f into main Sep 17, 2024
54 checks passed
@0xPxt 0xPxt deleted the flex-porting branch September 17, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants