add shielded hash verification

Zondax · Sep 20, 2024 · 5623c0d · 5623c0d
1 parent 8c8fe4d
commit 5623c0d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/src/parser_impl.c b/app/src/parser_impl.c
@@ -27,7 +27,9 @@ parser_error_t _read(parser_context_t *ctx, parser_tx_t *v) {
 
     CHECK_ERROR(validateTransactionParams(v))
 
-    CHECK_ERROR(verifyShieldedHash(ctx))
+    if(ctx->tx_obj->transaction.isMasp) {
+        CHECK_ERROR(verifyShieldedHash(ctx))
+    }
 
     if (ctx->offset != ctx->bufferLen) {
         return parser_unexpected_unparsed_bytes;

diff --git a/app/src/parser_impl_txn.c b/app/src/parser_impl_txn.c
@@ -1432,6 +1432,10 @@ parser_error_t verifyShieldedHash(parser_context_t *ctx) {
             return parser_invalid_target_hash;
         }
     }
+
+    if (ctx->tx_obj->transfer.has_shielded_hash && memcmp(ctx->tx_obj->transfer.shielded_hash.ptr, tx_id_hash, HASH_LEN) != 0) {
+        return parser_invalid_target_hash;
+    }
 #endif
 
     return parser_ok;