Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eclipsing variable examples #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

przemekmroz
Copy link
Collaborator

Eclipsing variables PR

Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things you can consider.

@@ -0,0 +1,32 @@
## Eclipsing variables (ecl)

Eclipsing variables are binary stars systems in which the orbital plane lies nearly in the line of sight of the observer. The binary components pass in front of one another from observer's perspective and so their combined brightness decreases periodically.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binary stars systems -> binary star systems
from observer's perspective -> from the observer's perspective

## Eclipsing variables (ecl)

Eclipsing variables are binary stars systems in which the orbital plane lies nearly in the line of sight of the observer. The binary components pass in front of one another from observer's perspective and so their combined brightness decreases periodically.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say something here briefly about the eclipses can be different shapes and depths, which you get to below?

![ZTF eclipsing](data/eclipsing.png)

#### Description
Eclipsing variables show regular, periodic "V-shape" dips in their phase folded light curves, which may be sharp or rounded, depending on the system. Their periods may range from minutes to years. Eclipse amplitudes vary from ~0.1 to several magnitudes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just survey sensitivity that prevents us from going below ~0.1? Maybe we explicitly call that out as for ZTF then.

![Period histogram of eclipsing variables](data/period__eclipsing.png)

### References and further reading:
- Graczyk et al. (2011) <a href="https://ui.adsabs.harvard.edu/abs/2011AcA....61..103G/abstract">The Optical Gravitational Lensing Experiment. The OGLE-III Catalog of Variable Stars. XII. Eclipsing Binary Stars in the Large Magellanic Cloud</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were writing out the whole citation I think, i.e. including journal and so on.

@dmitryduev
Copy link
Collaborator

@przemekmroz @mcoughlin ping!

1 similar comment
@dmitryduev
Copy link
Collaborator

@przemekmroz @mcoughlin ping!

@mcoughlin
Copy link
Collaborator

@dmitryduev Once @przemekmroz fixes, happy to approve.

@dmitryduev
Copy link
Collaborator

@przemekmroz @mcoughlin ping!

@dmitryduev dmitryduev removed their request for review September 30, 2021 00:14
@mcoughlin
Copy link
Collaborator

@dmitryduev maybe we just merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants