Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all quad ids for a ZTF field #76

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

saagar-parikh
Copy link
Contributor

Given a CCD and Quad range, get all quad ids in separate hdf5 files (one .h5 for each quad).

@saagar-parikh saagar-parikh marked this pull request as ready for review May 17, 2022 00:55
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad:
(i) Don't commit the output files
(ii) Merge your id's script into the existing one and use some command line flag to trigger your code.

.gitignore Outdated Show resolved Hide resolved
@@ -0,0 +1,256 @@
import argparse
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this just be done as a modification to the original script? i.e. if --all-quads or something, your path is triggered?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

tools/output/data.txt Outdated Show resolved Hide resolved
tools/secrets.json Outdated Show resolved Hide resolved
Set default output file and fixed --all-quads tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants