Fix science doc open.
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now uses a local HTTP server to serve docs which is much more straightfoward than trying to hack around all the quirks trying to serve a site via file:// URLs brings.
jsirois
commented
Mar 20, 2024
There was a problem hiding this comment.
This is almost verbatim ripped off https://github.com/pex-tool/pex/blob/main/pex/docs/server.py
I spent an embarrassing amount of time learning the WSGI spec and getting this working using gunicorn with its built in pidfile and daemon support only to find out late that it:
a.) Doesn't support Windows - which science does
b.) Has a hard-coded serve port bind failure retry loop that tries 5 times sleeping 1s between each - this defeats a snappy, try default port and fallback to ephemeral.
|
Hrm. Yeah - getting this to work on Windows block and it still does not. I'm going to convert to draft and ping you all again when I have Windows daemons / services / whatever I need - figured out. |
benjyw
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now uses a local HTTP server to serve docs which is much more
straightforward than trying to hack around all the quirks trying to
serve a site via file:// URLs brings.