Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable sso based on env type #6

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

bernattorras
Copy link
Contributor

@bernattorras bernattorras commented Nov 20, 2023

Changes proposed in this Pull Request

  • Enable or disable SSO depending on the environment type:
    • Disables SSO (if it's enabled already) on non-production sites
    • Enables SSO on production sites (if it's not enabled already)
  • Bump plugin version to 1.0.3

Testing instructions

  • Install and activate this version of the plugin on a production site and confirm that SSO is required in the login page
  • Install and activate this version of the plugin on a non-production site and confirm that SSO isn't required anymore

Mentions #1

@wpspecialprojects
Copy link
Contributor

Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:

  • includes/class-force-sso.php
  • to51-jetpack-force-sso.php

The error may be temporary. If the error persists, please contact a human (commit-ID: 3bbc4fd).

@bernattorras
Copy link
Contributor Author

I'm merging this fix into trunk because the previous fix wasn't deactivating SSO if it was already active in a non-production site.

@bernattorras bernattorras merged commit 332ca87 into trunk Nov 20, 2023
1 check passed
@bernattorras
Copy link
Contributor Author

@tommusrhodus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants