Merge pull request #134 from RyanGrange/issue129

Issue 129: Return primes list as read-only.
aalhour · May 27, 2020 · ad09171 · ad09171
2 parents 897712d + e97c2cf
commit ad09171
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/DataStructures/Common/PrimesList.cs b/DataStructures/Common/PrimesList.cs
@@ -184,11 +184,11 @@ public int GetPreviousPrime(int number)
         }
 
         /// <summary>
-        /// Returns the list of primes
+        /// Returns the read-only IList of primes
         /// </summary>
-        public List<int> GetAll
+        public IList<int> GetAll
         {
-            get { return _primes; }
+            get { return _primes.AsReadOnly(); }
         }
 
         /// <summary>

diff --git a/UnitTest/DataStructuresTests/PrimeListTest.cs b/UnitTest/DataStructuresTests/PrimeListTest.cs
@@ -1,4 +1,5 @@
-using DataStructures.Common;
+using System;
+using DataStructures.Common;
 using Xunit;
 
 namespace UnitTest.DataStructuresTests
@@ -11,5 +12,13 @@ public void DoTest()
             var instance = PrimesList.Instance;
             Assert.Equal(10000, instance.Count);
         }
+
+        [Fact]
+        public void PrimesListIsReadOnly()
+        {
+            var instance = PrimesList.Instance;
+            NotSupportedException ex = Assert.Throws<NotSupportedException>(() => instance.GetAll[0] = -1);
+            Assert.Equal("Collection is read-only.", ex.Message);
+        }
     }
 }