Adding a podcasts page to the website #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalmiray
requested changes
Nov 15, 2024
| @@ -31,7 +31,7 @@ jobs: | |||
| - name: Parse data | |||
| run: | | |||
| cd resources | |||
| ./jbang site.java ../java-champions.yml ../site/content/ | |||
| ./jbang site.java ../java-champions.yml ../podcasts.yml ../site/content/ | |||
There was a problem hiding this comment.
Podcasts have yet to be integrated into the site.
This step is not needed at the moment
There was a problem hiding this comment.
As the script expects this extra value, we need to keep it here to avoid the workflow to break. The new webpage is already created by the script, but I commented the link to it in the menu so you can first validate the new page before making it public.
|
@aalmiray, thanks for the remarks. They have been handled, and the merge request is ready for your re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I can't run jbake on my mac, but the generation of the new page seems to work OK.