Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html_of_jsx template #326

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Conversation

davesnx
Copy link
Contributor

@davesnx davesnx commented Jun 8, 2024

This might be broken, since current opam release expects > 5.0.0, but will release a new package (0.0.4) without the lower band on 5.

@aantron
Copy link
Owner

aantron commented Jul 24, 2024

Thank you! This looks amazing (as does the sibling mlx PR by @andreypopp).

I was trying this out with html_of_jsx 0.0.4 and Reason 3.11.0 installed, and got

File "dream/example/r-html_of_jsx/html_of_jsx.re", line 15, characters 41-42:
15 |       (_ => Dream.html(Jsx.render(<greet ~who="world" />))))),
                                              ^
Error: Syntax error

Do you know what's causing that?

@davesnx
Copy link
Contributor Author

davesnx commented Jul 24, 2024

Fixed the syntax, indeed is similar to mlx but with Reason syntax

@aantron
Copy link
Owner

aantron commented Jul 24, 2024

Thanks! I had to make these changes to get the example to compile. Could you take a quick look, just in case I am using something outdated? Would be very helpful, as I have no recent experience with JSX in Reason.

@aantron aantron merged commit d72f21d into aantron:master Jul 25, 2024
2 of 13 checks passed
@aantron
Copy link
Owner

aantron commented Jul 25, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants