New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: floating-point number serialization issue for non-normal values #992

Open

filzrev wants to merge 1 commit into aaubry:master from filzrev:fix-json-number-serialization

filzrev commented Oct 16, 2024 •

edited

Loading

This PR intended to fix #991.

What's changed in this PR

Replace formatter.FormatNumber(object value); call to ToString("G", CultureInfo.InvariantCulture).
- It's required to serialize special symbols (Nan/PositiveInfinite/NegativeInfinite) to JSON compatible string representation.
- Additionally explicitly specify format (G) to align YAML serialized value
Remove NumericRegex checks. Instead add IsNaN/IsInfinity checks
Add unit test code (SerializationOfNumericsAsJsonRountTrip)


          fix: floating-point number serialization issue for non-normal values

eb37834

peeveen mentioned this pull request

Serialized integral doubles/floats become strings. #994

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet