Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter mode in /authors not showing up on mobile #318

Closed
abartov opened this issue Apr 4, 2024 · 2 comments · Fixed by #325
Closed

Filter mode in /authors not showing up on mobile #318

abartov opened this issue Apr 4, 2024 · 2 comments · Fixed by #325
Assignees
Labels

Comments

@abartov
Copy link
Owner

abartov commented Apr 4, 2024

No description provided.

@damisul
Copy link
Collaborator

damisul commented Apr 10, 2024

Well... as far as I see main reason is that for mobile we did not created mobile filter for at all, see:

We can use same approach as we use in works browse page and render separate form for mobile UI, but I'd like to try to use Bootstrap's adaptive layout. It is a bit tricky, but Bootstrap allows to make same layout to looks differently on mobile and PC.
It maybe hard to keep current look for PC completely the same, but I can try to keep it as close to current look as possible.

Main benefit is that it will greatly simplify js code (as we'll have only one html form on page).
@abartov , WDYT? Can I spend some time to experiment with this?

@abartov
Copy link
Owner Author

abartov commented Apr 10, 2024

Yes, please do.

@damisul damisul linked a pull request Apr 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants