-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intellectual property enum for Person #336
Conversation
…with intellectual_property enum
38164a3
to
1fdb242
Compare
1fdb242
to
e58b9be
Compare
3f6b8e4
to
4bb960b
Compare
4bb960b
to
626f042
Compare
@damisul - I am testing this, and noticed what I missed in a previous PR: the manifestation/edit_metadata form has not been updated to offer the new intellectual property modes, and still has a boolean radio button. Please fix this. |
also: Manifestation.copyright? yields a NoMethodError
|
Hm... this is strange. I see this on my machine using current master (after this PR was merged): @abartov , are you sure you're using latest version of sources? |
And
Just checked and currently on 96th line of
|
Pardon me! Both are my mistake. I accidentally looked at the production branch. |
Updated person model and people table: replaced public_domain column with intellectual_property enum.
Fixed incongruous copyright report.
Also this PR contains changes to speedup ManifestationIdex rebuilding: I've added preloading of all involved persons and tags, and modified methods used to fetch authors/translators etc to be able to use preloaded data.
It allowed to reduce chewy:reset time for ManifestationIndex on my machine from 23 minutes to 11 minutes.
I propose to use 'Rebase and merge' policy for this PR to keep those changes separated in commit history.