Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to known-good header for StreamDeck Original V1 #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Subsentient
Copy link

Fixes #47

@abcminiuser
Copy link
Owner

What's odd is that I have a StreamDeck Original V1, and I can't see the shifting. Looking at the packet dumps between the old/new versions the only difference I can spot is the overall length, where the old code doesn't pad the packets to the report length boundary.

Can you please try the latest head, but with padding = bytearray() (i.e. no padding) in StreamDeckOriginalV1.py? In theory it shouldn't make any difference, but there might be a USB controller or firmware bug that's only showing up on some systems.

@Subsentient
Copy link
Author

What's odd is that I have a StreamDeck Original V1, and I can't see the shifting. Looking at the packet dumps between the old/new versions the only difference I can spot is the overall length, where the old code doesn't pad the packets to the report length boundary.

Can you please try the latest head, but with padding = bytearray() (i.e. no padding) in StreamDeckOriginalV1.py? In theory it shouldn't make any difference, but there might be a USB controller or firmware bug that's only showing up on some systems.

Just tried it, something must be going on because that fix doesn't work. Only the pull request does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top half of image is shifted right on Original StreamDeck V1
2 participants