Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project test dependencies to ensure green workflow #1371

Merged
merged 41 commits into from
Apr 11, 2024

Conversation

abhinavsingh
Copy link
Owner

No description provided.

abhinavsingh and others added 2 commits April 10, 2024 22:56
Add missing tutorial's link

(cherry picked from commit e459f93)
@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Apr 10, 2024
pre-commit-ci bot and others added 24 commits April 10, 2024 17:35
@abhinavsingh abhinavsingh changed the title April 2024 Update project test dependencies to ensure green workflow Apr 11, 2024
@abhinavsingh abhinavsingh merged commit ddc96d4 into develop Apr 11, 2024
49 checks passed
@abhinavsingh abhinavsingh deleted the april-2024 branch April 11, 2024 07:34
@@ -188,6 +188,7 @@ extend-ignore =
WPS613 # FIXME: unmatching super method access
WPS615 # FIXME: unpythonic setter/getter
PT027 # FIXME: use pytest.raises() instead of unittest-style 'assertRaises'
S507 # FIXME: Paramiko call with policy set to automatically trust the unknown host key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to ignore such exceptions inline instead of allowing the violations globally. This way you're in control and have to review the security implications of every such place.

Comment on lines +7 to +18
# See https://github.com/yaml/pyyaml/issues/724#issuecomment-1638587228
pyyaml==5.3.1
# PIN to fix:
# The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0;
# it therefore cannot be built with this version.
sphinxcontrib-applehelp==1.0.2
sphinxcontrib-devhelp==1.0.2
sphinxcontrib-htmlhelp==2.0.0
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-serializinghtml==1.1.5
sphinxcontrib-towncrier==0.2.1a0
towncrier==21.3.0
Copy link
Contributor

@webknjaz webknjaz Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavsingh this change is incorrect — the .in files are supposed to only list the direct deps, not transitive, not pinned. All the pins must go to the constraint files. Otherwise, it's pointless to use separate constraint files as lockfiles as they'd contain exactly the same content with no ability to track which deps are used directly and which ones happen to be pulled in additionally.

Comment on lines +177 to +180
# FIXME: VERIFIED6 NOT ASSERTED BECAUSE WE STARTED GETTING EMPTY RESPONSE FROM UPSTREAM
# AFTER CHANGE FROM HTTPBIN TO HTTPBINGO. This test works and passes perfectly when
# run from a local system
EXIT_CODE=$(( $VERIFIED1 || $VERIFIED2 || $VERIFIED3 || $VERIFIED4 || $VERIFIED5 ))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually is a bug, identified in #1433 (comment) and fixed in #1434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants