Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write GFA header #1293

Merged
merged 3 commits into from
May 21, 2024
Merged

Write GFA header #1293

merged 3 commits into from
May 21, 2024

Conversation

asl
Copy link
Member

@asl asl commented May 14, 2024

  • GFA version used
  • Producer (SPAdes) version

Also, unified version handling while there.

@asl asl requested a review from andrewprzh May 14, 2024 00:11
@asl asl added this to the SPAdes 4.0 milestone May 14, 2024
@asl asl mentioned this pull request May 14, 2024
12 tasks
Base automatically changed from gfa-1.2-doc to next May 14, 2024 22:06
Copy link
Collaborator

@andrewprzh andrewprzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

if (CMAKE_MATCH_1 STREQUAL "")
set(SPADES_FLAVOUR "SPAdes")
else()
set(SPADES_FLAVOUR "${CMAKE_MATCH_1}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMAKE_MATCH_N looks like a creepy logic to someone who is not that familiar with cmake :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Very cmake-ish.

@asl asl merged commit 5bc1bfe into next May 21, 2024
92 checks passed
@asl asl deleted the gfa-1.2-hdr branch May 21, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants