Move builder creation log after required fields check

ably · Nov 18, 2022 · 0c143bd · 0c143bd
1 parent 75b6b05
commit 0c143bd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/publishing-sdk/src/main/java/com/ably/tracking/publisher/PublisherBuilder.kt b/publishing-sdk/src/main/java/com/ably/tracking/publisher/PublisherBuilder.kt
@@ -74,11 +74,11 @@ internal data class PublisherBuilder(
 
     @RequiresPermission(anyOf = [ACCESS_COARSE_LOCATION, ACCESS_FINE_LOCATION])
     override fun start(): Publisher {
-        logHandler?.v("$TAG Creating a publisher instance")
         if (isMissingRequiredFields()) {
             logHandler?.v("$TAG Creating a publisher instance failed due to missing required fields")
             throw BuilderConfigurationIncompleteException()
         }
+        logHandler?.v("$TAG Creating a publisher instance")
         // All below fields are required and above code checks if they are nulls, so using !! should be safe from NPE
         return DefaultPublisher(
             DefaultAbly(connectionConfiguration!!, logHandler),

diff --git a/subscribing-sdk/src/main/java/com/ably/tracking/subscriber/SubscriberBuilder.kt b/subscribing-sdk/src/main/java/com/ably/tracking/subscriber/SubscriberBuilder.kt
@@ -29,11 +29,11 @@ internal data class SubscriberBuilder(
         this.copy(logHandler = logHandler)
 
     override suspend fun start(): Subscriber {
-        logHandler?.v("$TAG Creating a subscriber instance")
         if (isMissingRequiredFields()) {
             logHandler?.v("$TAG Creating a subscriber instance failed due to missing required fields")
             throw BuilderConfigurationIncompleteException()
         }
+        logHandler?.v("$TAG Creating a subscriber instance")
         // All below fields are required and above code checks if they are nulls, so using !! should be safe from NPE
         return DefaultSubscriber(
             DefaultAbly(connectionConfiguration!!, logHandler),