Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for publisher to only emit events sent over the Ably network #913

Open
AndyTWF opened this issue Jan 16, 2023 · 1 comment
Open
Labels
enhancement New feature or improved functionality.

Comments

@AndyTWF
Copy link
Contributor

AndyTWF commented Jan 16, 2023

At the moment, the locations SharedFlow on the publisher is emitted to for any enhanced location update received by Mapbox, regardless of whether or not it was sent to subscribers over the Ably network. This can make testing problematic when we're comparing what the publisher sends and the subscriber receives. Customers listening may also only want to be notified of updates that have been sent out.

We could therefore make a way in which the publisher only emits events that have been sent over the Ably network, such as:

  • Having a separate flow with a contract that events are only emitted once we know they're on the Ably network
  • Adding a builder option that would change the behaviour of the existing locations slow to achieve the same effect

Original conversation: https://ably-real-time.slack.com/archives/C01EPJENRD0/p1673630012583289

@sync-by-unito
Copy link

sync-by-unito bot commented Feb 16, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

1 participant