Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README and unity doc #1207

Merged
merged 39 commits into from
Mar 3, 2023
Merged

Update README and unity doc #1207

merged 39 commits into from
Mar 3, 2023

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Feb 11, 2023 •
edited
Loading

Fixed #1204

sacOO7 and others added 23 commits February 20, 2022 18:09
@sacOO7
Exported custom simplistic unity editor layout
b25cccc
@sacOO7
Added unity_setup documentation
449aaad
@sacOO7
Added doc images to local env. setup
7400c47
@sacOO7
Updated setup script with gaming tools C++ installation for IL2CPP build
36f87e1 
support
@sacOO7
Added readme file with basic project related information
d4ca02a
@sacOO7
Updated readme setup file
006e365
@sacOO7
Updated setup.md title
7508396
@sacOO7
updated readme with downloading and importing the unitypackage
f084d1b
@sacOO7
Merge branch 'feature/unity-integration' into unity-integration/docum…
751410a 
…entation
@tomkirbygreen
Merge pull request #1124 from ably/unity-integration/documentation
be4e68c 
Unity documentation
@sacOO7
Updated unity README doc title and importing package step
c3d0514
@sacOO7
Renamed setup.md file to SETUP.md
fe16a86
@sacOO7
Updated netstandard assemblyInfo, made unity package names explicit/v…
c3ba5b8 
…erbose
@sacOO7
Removed unnecessary ably-dotnet vsconfig folder
ad7cb98
@sacOO7
Merge pull request #1125 from ably/unity-integration/update-assemblyInfo
7c40f42 
Update netstandard assemblyInfo
@sacOO7
Fixed unity README.md and SETUP.md formatting issues
d01368e
@sacOO7
Refactored README.md and SETUP.md file
7cffbd5
@sacOO7
Merge pull request #1128 from ably/unity-integration/tests
fee6ad6 
[Unity Integration] Add Editmode and Playmode tests
@sacOO7
Replaced vsi_modify_2 jpg file with png, updated SETUP file for the same
3408cac
@sacOO7
Updated unity README as per comments
766ed9e
@sacOO7
Updated unity setup doc as per comments
0cc1b80
@sacOO7
Updated README with unsupported platforms -> webGL
c68843f
@sacOO7
Updated README for authCallback return type
5c7eef6
@sacOO7 sacOO7 changed the title Update README Update supported platforms and unity doc Feb 11, 2023
@sacOO7 sacOO7 changed the title Update supported platforms and unity doc Update README and unity doc Feb 11, 2023
@sacOO7 sacOO7 marked this pull request as ready for review February 11, 2023 20:58
@sacOO7 sacOO7 self-assigned this Feb 16, 2023
tomczoink
tomczoink suggested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@tomczoink tomczoink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the recommended steps seem to work for me, just a few grammatical and formatting changes I think might help.

README.md Outdated Show resolved Hide resolved
unity/CONTRIBUTING.md Outdated Show resolved Hide resolved
unity/CONTRIBUTING.md Outdated Show resolved Hide resolved
unity/CONTRIBUTING.md Outdated Show resolved Hide resolved
unity/CONTRIBUTING.md Outdated Show resolved Hide resolved
unity/README.md Outdated Show resolved Hide resolved
unity/README.md Outdated Show resolved Hide resolved
unity/README.md Outdated Show resolved Hide resolved
unity/README.md Outdated Show resolved Hide resolved
unity/README.md Outdated Show resolved Hide resolved
tomczoink
tomczoink approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@tomczoink tomczoink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot temporarily deployed to staging/pull/1207/features March 3, 2023 19:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1207/features March 3, 2023 19:36 Inactive
@sacOO7 sacOO7 merged commit d7c9c85 into main Mar 3, 2023
@sacOO7 sacOO7 deleted the fix/update-readme branch March 3, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomczoink tomczoink tomczoink approved these changes

@marto83 marto83 Awaiting requested review from marto83

@owenpearson owenpearson Awaiting requested review from owenpearson

Assignees

@sacOO7 sacOO7

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update README + Unity Documentation
3 participants
@sacOO7 @tomczoink @tomkirbygreen