Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unnecessary recover error test #1291

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Delete unnecessary recover error test #1291

merged 1 commit into from
Aug 20, 2024

Commits on Aug 13, 2024

  1. Delete unnecessary recover error test 

    The test removed in this commit expects that using an invalid recovery
key leads to an ERROR protocol message being returned which thus fails
the connection, but this isn't part of the spec, we make no guarantee
that invalid recovery keys are rejected, and in fact returning a
CONNECTED protocol message with the error field indicating the recovery
key was invalid is a perfectly good response, which is in fact what we
will start to do in the future.

The functionality that an ERROR protocol message is treated as fatal
and fails the connection is still tested elsewhere, so rmeoving this
test doesn't materially reduce the amount of test coverage.

Signed-off-by: Lewis Marshall <[email protected]>
    @lmars
    lmars committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3c10353 View commit details
    Browse the repository at this point in the history