feat: protect from multiple MethodChannel.Result invocation
#489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/489/features
ttypic
force-pushed
the
more-safe-channel-wrapper
branch
from
eb5e533
to
50cc9bb
Compare
github-actions
bot
temporarily deployed
to
staging/pull/489/features
sacOO7
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
LGTM!
Just in case, you might like to add a test to avoid a case where method call consistently throws exception.
Based on what I know, we shouldn't be posting callbacks on main threads, it can block app UI execution and main thread exceptions should be handled by developers themselves. Since this is an old working code, there might be some reason : )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to SDK-3906