feat: setOnBackgroundMessage() is now a Future<void> that will await for the function to complete. #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made the call to the onPushBackgroundMessage await for the handler to complete.
I changed handleBackgroundMessage() to become a Future<void> and async/await.
I made the BackgroundMessageHandler a Future<void> instead of void so that we can async/await for it to be completed.
handleBackgroundMessage now handles when _onBackgroundMessage is defined as void or Future<void> It checks to see if it's a Future and then awaits it if it is.
Changed the cast on BackgroundMessageHandler to dynamic, this allows it to be defined as both void and Future<void>
github-actions
bot
temporarily deployed
to
staging/pull/499/features
github-actions
bot
temporarily deployed
to
staging/pull/499/features
github-actions
bot
temporarily deployed
to
staging/pull/499/features
github-actions
bot
temporarily deployed
to
staging/pull/499/dartdoc
ttypic
force-pushed
the
test-run-ci-for-forked-pr
branch
from
9663b8a
to
997c3f2
Compare
ttypic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied #498