Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4629] fix: propagate id and key fields for connection object for Android and iOS #505

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Feb 26, 2024

Resolves #502
Jira issue ECO-4629

Add key and id to ConnectionStateChange event, updated example app

@ttypic ttypic changed the title [ECO-4629] fix propagate id and key fields for connection object for Android [ECO-4629] fix: propagate id and key fields for connection object for Android Feb 26, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/505/features February 26, 2024 10:21 Inactive
@ttypic ttypic requested a review from sacOO7 February 26, 2024 10:21
@github-actions github-actions bot temporarily deployed to staging/pull/505/dartdoc February 26, 2024 10:22 Inactive
@ttypic ttypic force-pushed the ECO-4629/fix-connection-fields branch from 6cac7f8 to 37ca254 Compare February 26, 2024 10:32
@github-actions github-actions bot temporarily deployed to staging/pull/505/features February 26, 2024 10:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/505/dartdoc February 26, 2024 10:32 Inactive
Add `key` and `id` to `ConnectionStateChange` event, updated example app
@ttypic ttypic force-pushed the ECO-4629/fix-connection-fields branch from 37ca254 to 4ead8d1 Compare February 26, 2024 12:25
@github-actions github-actions bot temporarily deployed to staging/pull/505/features February 26, 2024 12:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/505/dartdoc February 26, 2024 12:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/505/features February 26, 2024 14:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/505/dartdoc February 26, 2024 14:31 Inactive
Copy link
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@maratal maratal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maratal maratal changed the title [ECO-4629] fix: propagate id and key fields for connection object for Android [ECO-4629] fix: propagate id and key fields for connection object for Android and iOS Feb 28, 2024
@ttypic ttypic merged commit 096daf4 into main Feb 28, 2024
8 checks passed
@ttypic ttypic deleted the ECO-4629/fix-connection-fields branch February 28, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

How do we get connectionId from connection?
3 participants