Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #514

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Update README #514

merged 8 commits into from
Mar 13, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Mar 12, 2024 •
edited
Loading

@github-actions github-actions bot temporarily deployed to staging/pull/514/features March 12, 2024 04:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/dartdoc March 12, 2024 04:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/features March 12, 2024 05:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/dartdoc March 12, 2024 05:03 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/features March 12, 2024 05:06 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/dartdoc March 12, 2024 05:06 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/features March 12, 2024 05:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/dartdoc March 12, 2024 05:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/features March 12, 2024 05:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/dartdoc March 12, 2024 05:27 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/features March 12, 2024 05:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/514/dartdoc March 12, 2024 05:36 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review March 12, 2024 12:51
@sacOO7 sacOO7 requested review from ttypic and maratal March 12, 2024 13:06
ttypic
ttypic requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating Readme! Looks good, left couple of comments

CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@sacOO7 sacOO7 requested a review from ttypic March 13, 2024 06:09
ttypic
ttypic approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Mar 13, 2024

LGTM

Thanks !

@sacOO7 sacOO7 merged commit 9769cce into main Mar 13, 2024
8 checks passed
@sacOO7 sacOO7 deleted the fix/documentation branch March 13, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@maratal maratal Awaiting requested review from maratal

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ably-flutter README
2 participants
@sacOO7 @ttypic