Merge pull request #940 from ably/release/1.2.29

Release/1.2.29
ably · May 17, 2023 · 52318c1 · 52318c1
2 parents a0460ac + d289ed1
commit 52318c1
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,18 @@
 # Change Log
 
+## [1.2.29](https://github.com/ably/ably-java/tree/v1.2.29)
+
+[Full Changelog](https://github.com/ably/ably-java/compare/v1.2.28...v1.2.29)
+
+**Fixed bugs:**
+
+- RTN23a: Transport not disconnecting after TTL passed [\#932](https://github.com/ably/ably-java/issues/932)
+
+**Merged pull requests:**
+
+- fix: transport not disconnecting after ttl passed [\#939](https://github.com/ably/ably-java/pull/939) ([AndyTWF](https://github.com/AndyTWF))
+- fix\(ConnectionManager\): don't check state before sending close message [\#938](https://github.com/ably/ably-java/pull/938) ([owenpearson](https://github.com/owenpearson))
+
 ## [1.2.28](https://github.com/ably/ably-java/tree/v1.2.28)
 
 [Full Changelog](https://github.com/ably/ably-java/compare/v1.2.27...v1.2.28)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -191,7 +191,7 @@ You may wish to make changes to Ably Java or Ably Android, and test it immediate
 - Open the directory printed from the output of that command. Inside that folder, get the `ably-android-x.y.z.aar`, and place it your Android project's `libs/` directory. Create this directory if it doesn't exist.
 - Add an `implementation` dependency on the `.aar`:
 ```groovy
-implementation files('libs/ably-android-1.2.28.aar')
+implementation files('libs/ably-android-1.2.29.aar')
 ```
 - Add the `implementation` (not `testImplementation`) dependencies found in `dependencies.gradle` to your project. This is because the `.aar` does not contain dependencies.
 - Build/run your application.

diff --git a/README.md b/README.md
@@ -20,13 +20,13 @@ Include the library by adding an `implementation` reference to `dependencies` bl
 For [Java](https://mvnrepository.com/artifact/io.ably/ably-java/latest):
 
 ```groovy
-implementation 'io.ably:ably-java:1.2.28'
+implementation 'io.ably:ably-java:1.2.29'
 ```
 
 For [Android](https://mvnrepository.com/artifact/io.ably/ably-android/latest):
 
 ```groovy
-implementation 'io.ably:ably-android:1.2.28'
+implementation 'io.ably:ably-android:1.2.29'
 ```
 
 The library is hosted on [Maven Central](https://mvnrepository.com/repos/central), so you need to ensure that the repository is referenced also; IDEs will typically include this by default:

diff --git a/android/build.gradle b/android/build.gradle
@@ -31,7 +31,7 @@ android {
         minSdkVersion 19
         targetSdkVersion 30
         // This MUST be incremented by 1 on each ably-java release
-        versionCode 3
+        versionCode 4
         versionName version
         setProperty('archivesBaseName', "ably-android-$versionName")
         testInstrumentationRunner 'android.support.test.runner.AndroidJUnitRunner'

diff --git a/common.gradle b/common.gradle
@@ -3,7 +3,7 @@ repositories {
 }
 
 group = 'io.ably'
-version = '1.2.28'
+version = '1.2.29'
 description = 'Ably java client library'
 
 tasks.withType(Javadoc) {

diff --git a/lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java b/lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java
@@ -88,7 +88,7 @@ public void realtime_websocket_param_test() {
              * Defaults.ABLY_AGENT_PARAM, as ultimately the request param has been derived from those values.
              */
             assertEquals("Verify correct lib version", requestParameters.get("agent"),
-                    Collections.singletonList("ably-java/1.2.28 jre/" + System.getProperty("java.version")));
+                    Collections.singletonList("ably-java/1.2.29 jre/" + System.getProperty("java.version")));
 
             /* Spec RTN2a */
             assertEquals("Verify correct format", requestParameters.get("format"),