Turn off continue-on-error in CI
#398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest that we merge this one even though CI is failing (given that the tests were always failing but it was just hidden before). |
We want the workflow run to fail if any of the jobs fails. The motivation for the current configuration is not clear to me, but I’m guessing the idea was that the failure of a single job shouldn’t cancel the others. Turning off fail-fast should do the same thing. (Copied from ably-js commit ddef9f7.)
lawrence-forooghian
force-pushed
the
fail-ci-if-any-job-fails
branch
from
1b3faa2
to
c60134b
Compare
|
@lawrence-forooghian is this implemented in other SDKs as well? |
As mentioned above, we do it in ably-js. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the workflow run to fail if any of the jobs fails.
The motivation for the current configuration is not clear to me, but I’m guessing the idea was that the failure of a single job shouldn’t cancel the others. Turning off fail-fast should do the same thing.
(Copied from ably-js commit ddef9f7.)