Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4058][Protocol-2] Fix protocol 2 tests #411

Closed
wants to merge 65 commits into from
Closed

[ECO-4058][Protocol-2] Fix protocol 2 tests #411

wants to merge 65 commits into from

Commits on Jun 6, 2024

  1. Fix failing test due to incorrect logging of channel name in 

    incoming_message_dispatcher
    @sacOO7
    sacOO7 committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5facf99 View commit details
    Browse the repository at this point in the history

  2. updated protocol_message invalid check since message serial is only r… 

    …eceived on ack/nack
    @sacOO7
    sacOO7 committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3ab6054 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Fixed imports and typos for RecoveryKeyContext while creating recover… 

    …y key
    @sacOO7
    sacOO7 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    968c832 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Fixed setting channel serial for list of given channel serials

    @sacOO7
    sacOO7 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    cb9c2cf View commit details
    Browse the repository at this point in the history

  2. Added ablyextensions to check for 

    1. nil or empty string
2. fetch with default value for hash
    @sacOO7
    sacOO7 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    29635ed View commit details
    Browse the repository at this point in the history

  3. Fixed connection_spec resume/recover tests

    @sacOO7
    sacOO7 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ba8e6b0 View commit details
    Browse the repository at this point in the history

  4. removed unnecessary use of connection resumed callbacks

    @sacOO7
    sacOO7 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1be434f View commit details
    Browse the repository at this point in the history

  5. Fixed error message for msgserial while generating json from message

    @sacOO7
    sacOO7 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    446166a View commit details
    Browse the repository at this point in the history

  6. Reorganized configure_new for connection key and id

    @sacOO7
    sacOO7 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9574830 View commit details
    Browse the repository at this point in the history

  7. Replaced recovery_key usages with create_recovery_key in all tests

    @sacOO7
    sacOO7 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    aeb2e2b View commit details
    Browse the repository at this point in the history

  8. Fixed usage of configure_new for connection key and connection id

    @sacOO7
    sacOO7 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    897bccf View commit details
    Browse the repository at this point in the history

  9. removed test for server incorrectly sending duplicate message. 

    checks for the same are dependent on connection serial.
    @sacOO7
    sacOO7 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    cfe0820 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Updated message_spec test for receiving channel data after resume

    @sacOO7
    sacOO7 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e2a8f37 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary message serial check test for ack/nack message

    @sacOO7
    sacOO7 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9b3add8 View commit details
    Browse the repository at this point in the history

  3. updated default retry count to 1 on the CI to fast running tests

    @sacOO7
    sacOO7 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    16c02c8 View commit details
    Browse the repository at this point in the history

  4. Fixed channel attach mechanism where attach was being sent in a connect/ 

    disconnect loop.
Fixed channel attaching related failing tests
    @sacOO7
    sacOO7 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2fb73a1 View commit details
    Browse the repository at this point in the history

  5. updated channel spec tests to run only after channel is attached

    @sacOO7
    sacOO7 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    86cce8a View commit details
    Browse the repository at this point in the history

  6. Fixed rest channel acceptance tests, updated with correct error messages 

    sent from server
    @sacOO7
    sacOO7 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f3db64a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Revert "Fixed rest channel acceptance tests, updated with correct err… 

    …or messages"

This reverts commit f3db64a.
    @sacOO7
    sacOO7 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    eb4107f View commit details
    Browse the repository at this point in the history

  2. Fixed channel spec tests, removed unnecessary connection connected ch… 

    …ecks
    @sacOO7
    sacOO7 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e7b7689 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Fixed presence get tests, added code to wait till connected

    @sacOO7
    sacOO7 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ea9bc6e View commit details
    Browse the repository at this point in the history

  2. Fixed presence tests, added code to ensure client is connectd before … 

    …channel attach
    @sacOO7
    sacOO7 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7634e6b View commit details
    Browse the repository at this point in the history

  3. updated generic presence test helpers with appropriate test names

    @sacOO7
    sacOO7 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    23c6fd2 View commit details
    Browse the repository at this point in the history

  4. Fixed test for presencemap and local member map when channel enters 

    detached state
    @sacOO7
    sacOO7 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ada53ee View commit details
    Browse the repository at this point in the history

  5. Fixed code to include presence id while entering local presence members

    @sacOO7
    sacOO7 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    eb300d9 View commit details
    Browse the repository at this point in the history

  6. Fixed message_spec flaky test, implemented publish after subscribing … 

    …to channel
    @sacOO7
    sacOO7 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    194b537 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. updated presence local member enter test whe attach resume and presen… 

    …ce flag is false
    @sacOO7
    sacOO7 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    55d7428 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Fixed presence test for channel presence update, added connected check 

    before proceeding channel attach or detach
    @sacOO7
    sacOO7 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8c0db78 View commit details
    Browse the repository at this point in the history

  2. Fixed flaky presence leave test where client_id was being sent 

    instead of client_msg_serial as a mock leave message
    @sacOO7
    sacOO7 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    b952468 View commit details
    Browse the repository at this point in the history

  3. reverted tests default retry count to 3

    @sacOO7
    sacOO7 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d13050e View commit details
    Browse the repository at this point in the history

  4. Fixed connection resume, added check to see if connection state ttl h… 

    …as passed
    @sacOO7
    sacOO7 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    25f4c22 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Added implementation to send ATTACH msg immediately, only when state … 

    …is CONNECTED
    @sacOO7
    sacOO7 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5d34b60 View commit details
    Browse the repository at this point in the history

  2. Refactored code to accomodate forced attach on client connected

    @sacOO7
    sacOO7 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c2248cc View commit details
    Browse the repository at this point in the history

  3. reverted need to make sure cliets connected for setup_test

    @sacOO7
    sacOO7 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4889cc4 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Fixed failing tests related to channel_spec

    @sacOO7
    sacOO7 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    6e449bd View commit details
    Browse the repository at this point in the history

  2. Added msgserial check back to the protocol_message

    @sacOO7
    sacOO7 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    38ef504 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Implemented code to cancel pending_state_change_timer via internal state 

    change event instead of emitter callback
    @sacOO7
    sacOO7 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    656b38a View commit details
    Browse the repository at this point in the history

  2. Updated presence test to check for entered local members

    @sacOO7
    sacOO7 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6fb9d4c View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Refactored cancel_pending_state_change_timer, renamed to notify_state… 

    …_change
    @sacOO7
    sacOO7 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ff6532b View commit details
    Browse the repository at this point in the history

  2. Fixed skipped flaky test for channel attach with provided client options

    @sacOO7
    sacOO7 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    36d7a7e View commit details
    Browse the repository at this point in the history

  3. Refactored doc/helper comments for sending attach message

    @sacOO7
    sacOO7 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    873b093 View commit details
    Browse the repository at this point in the history

  4. Ignored failing test caused by realtime sandbox changes, will be fixe… 

    …d as a

part of separate PR
    @sacOO7
    sacOO7 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    489de5c View commit details
    Browse the repository at this point in the history

  5. refactored AblyExtensions, renmaed Hash accessors with appropriate na… 

    …ming
    @sacOO7
    sacOO7 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3293448 View commit details
    Browse the repository at this point in the history

  6. Refactored doc comments, log messages and removed use of alias [] for… 

    … get
    @sacOO7
    sacOO7 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    66e323e View commit details
    Browse the repository at this point in the history

  7. Moved implementation for setting channel serial below valid protocol … 

    …message check
    @sacOO7
    sacOO7 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    704ee49 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. refactored ATTACH and DETACH msg send implementation, reorganised timers

    @sacOO7
    sacOO7 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2de53b5 View commit details
    Browse the repository at this point in the history

  2. Refactored detach message send impl

    @sacOO7
    sacOO7 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f21e570 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'feature/protocol-2-presence' into feature/protocol-2-tests 

    # Conflicts:
#	lib/ably/realtime/client/incoming_message_dispatcher.rb
#	lib/ably/realtime/presence/presence_manager.rb
    @sacOO7
    sacOO7 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    931b0a7 View commit details
    Browse the repository at this point in the history

  2. updated skipped tests, marked as unskipped

    @sacOO7
    sacOO7 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ae9ec6b View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Fixed failing test for push admin web target

    @sacOO7
    sacOO7 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    73b502f View commit details
    Browse the repository at this point in the history

  2. rest/channel_spec: fix test checking error messages 

    Replace error message checks with error code checks.
Error messages are not guaranteed to be consistent across versions/systems
but the error codes are.
    @Zariel
    Zariel committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6627639 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Refactored attach, removed forced_attach flag for sending attach message

    @sacOO7
    sacOO7 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8f6a1b0 View commit details
    Browse the repository at this point in the history

  2. Refactored request_attach method to include reason as param

    @sacOO7
    sacOO7 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ce628e7 View commit details
    Browse the repository at this point in the history

  3. Fixed request_attach, set attaching state first, then send attach pro… 

    …to msg
    @sacOO7
    sacOO7 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    0af9002 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Added test to check for duplicate attach message sent or received

    @sacOO7
    sacOO7 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    57f9d0b View commit details
    Browse the repository at this point in the history

  2. Update spec/acceptance/rest/channel_spec.rb

    @sacOO7
    sacOO7 authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    69ceaee View commit details
    Browse the repository at this point in the history

  3. Merge pull request #422 from ably/tests/fix-error-checks 

    rest/channel_spec: fix test checking error messages
    @sacOO7
    sacOO7 authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    cb684b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Merge branch 'feature/integration-protocol-2' into feature/protocol-2… 

    …-tests

# Conflicts:
#	lib/ably/realtime/channel.rb
#	lib/ably/realtime/channel/channel_manager.rb
#	lib/ably/realtime/channel/channel_state_machine.rb
#	lib/ably/realtime/connection.rb
    @sacOO7
    sacOO7 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b03bc7e View commit details
    Browse the repository at this point in the history

  2. Skipped clientId related tests because of lack of clarity related to … 

    …spec
    @sacOO7
    sacOO7 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b77870f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/protocol-2-tests

    @sacOO7
    sacOO7 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    62ab447 View commit details
    Browse the repository at this point in the history

  4. Refactored connection_failures_spec, removed unnecessary variables

    @sacOO7
    sacOO7 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5b9e955 View commit details
    Browse the repository at this point in the history

  5. modified default retry count to 1 for running ruby tests

    @sacOO7
    sacOO7 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    863503c View commit details
    Browse the repository at this point in the history

  6. Fixed logger msg for queuing outgoing msg

    @sacOO7
    sacOO7 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    73ad05c View commit details
    Browse the repository at this point in the history

  7. Revert "modified default retry count to 1 for running ruby tests" 

    This reverts commit 863503c.
    @sacOO7
    sacOO7 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    fe1d084 View commit details
    Browse the repository at this point in the history

  8. Fixed typo for unit test, replaced auth_connect with auto_connect

    @sacOO7
    sacOO7 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6ec2ff4 View commit details
    Browse the repository at this point in the history