Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made ChannelDetails.status and ChannelStatus.occupancy optional #1455

Closed
wants to merge 1 commit into from

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Jun 12, 2022

As mentioned by @lawrence-forooghian in this and this comments, both ChannelDetails.status and ChannelStatus.occupancy should be optional.

@owenpearson
Copy link
Member

Hey @maratal, these types should actually stay non-nullable - the confusion here is actually down to the documentation for ChannelStatus being misleading. The type is used for lifecycle events sent with the channel.lifecycle reactor source (see here), so these fields are documented as nullable because in that context they are. When using the REST API these fields will always exist so you should leave the spec as it is and change the ably-cocoa PR to make these fields non-nullable.

I've created #1456 to address this on the docs side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants