Merge Integration/3.0.0 into main
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit 63affff. We removed this property in cf35f3d but subsequently re-introduced it in 63affff after deciding that we did not want to make breaking API changes in specification version 2. Now that we’re starting work on version 3, we can remove it again. In line with the guidance of CONTRIBUTING.md, which says that a specification change that necessitates a major specification version increase should be accompanied by said increase, here we bump the major version to 3. Note that since we’re currently working on an integration branch for specification version 3 and development is still ongoing on version 2, the specification version number mentioned in RTN16m* may need to be updated before merging the integration branch into `main`.
This reverts commit 285e375 (but using the latest guidance for how to document a replaced spec point). We introduced this functionality in 1197e58 but subsequently removed it in 285e375 after deciding that we did not want to make breaking API changes in specification version 2. Now that we’re starting work on version 3, we can reintroduce it. Same comment as 69e1973 re needing to update "replaced in" spec version before merging integration branch into `main` applies here too.
CSV2a says that the protocol version is an integer.
Reintroduce breaking API changes for specification 3.0.0
There’s still a question of how this method is meant to behave if the user also specifies an `X-Ably-Header` header in the `headers` parameter. But it’s a question that equally applied before adding the `version` parameter, so I’ve captured it in a separate issue #144. Same comment as 69e1973 re needing to update "replaced in" spec version before merging integration branch into `main` applies here too.
Tweak spec for `Rest.request`’s `version` param
Untyped stats
mattheworiordan
approved these changes
Jul 4, 2023
I think this should have been done in a731d12; Stats.entries is just a Dict and so presumably there’s no special handling of absent values.
Remove TS2
|
Converting this one to a draft whilst sorting out protocol version stuff. |
Merge `main` into `integration/3.0.0`
…-into-3.0.0 I’ve accepted the spec version of 2.1.0, which clashes with the version of 3.0.0 that I introduced in 69e1973. I believe that my version bump in that commit was a mistake due to a misunderstanding of the CONTRIBUTING guidelines.
Merge `main` into `integration/3.0.0`
|
I'm going to merge this PR — the only reason the |
lawrence-forooghian
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.