-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump protocol version to 3 #173
Conversation
@SimonWoolf you mentioned on Slack that "you can request flat stats even with library protocol v2, if there's some particular reason you don't want to upgrade the lib protocol version yet, by specifying |
ef62bcb
to
e219780
Compare
sure -- only thing to bear in mind is that v=3 also triggers the new batched response, which means it's a breaking api change for anyone using rest.request() to do batched responses, which means that change should probably be made only in a library new major version, per semver. (But you'd probably want to do that anyway because completely changing the type of the rest.stats() response is also a breaking api change) |
That probably means that alongside this protocol bump I should update the batch-related spec points to remove the requirement that they pass the
I think this is no longer an issue now that |
(I'll need to merge |
sure go for it
yeah exactly, it fixes this problem for future breaking changes, but can't really do it retrospectively
I've changed the protection rules, you shouldn't need a pr review for a routine rebase of an integration branch, you can now self-review |
e219780
to
c48464a
Compare
I've pushed a new commit for the batch changes, mind re-reviewing please @owenpearson? |
c48464a
to
447a528
Compare
447a528
to
2bb76c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
2bb76c9
to
b46cf2d
Compare
In order to get the flattened stats API (this change should have come in a731d12).