Spec: clarify & refactor the relationship between channel and connection state #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonWoolf
force-pushed
the
clarify-channel-connection-state
branch
from
2b032a0
to
7561c65
Compare
sacOO7
requested changes
Jun 17, 2024
…ion state Internal discussion: https://ably-real-time.slack.com/archives/C8SPU4589/p1718631357934699?thread_ts=1718115075.720879&cid=C8SPU4589 This is not a behaviour change, just a wording refactor to clarify, since from the existing wording of RTL4i in particular ("do the operation once the connection state is @connected@") wasn't very clear. Refactored the concrete action into RTL3d and made RTL4i and RTN15c6/7 just reference that.
Co-authored-by: sachin shinde <[email protected]>
Co-authored-by: sachin shinde <[email protected]>
SimonWoolf
force-pushed
the
clarify-channel-connection-state
branch
from
79590b8
to
7a6b80e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal discussion: https://ably-real-time.slack.com/archives/C8SPU4589/p1718631357934699?thread_ts=1718115075.720879&cid=C8SPU4589
This is not a behaviour change, just a tweak to clarify, since from the existing wording of RTL4i in particular ("do the operation once the connection state is @connected@") wasn't very clear. Refactored the concrete action into RTL3d and made RTL4i and RTN15c6/7 just reference that.