Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace packaging with packvers in src/scripts #71

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Replace packaging with packvers in src/scripts #71

merged 1 commit into from
Jan 12, 2023

Conversation

swastkk
Copy link
Contributor

@swastkk swastkk commented Jan 5, 2023

@swastkk
Copy link
Contributor Author

swastkk commented Jan 7, 2023

@pombredanne review please :")

@swastkk swastkk mentioned this pull request Jan 9, 2023
Merged
@swastkk swastkk changed the title Import update in src/scripts/utils_dejacode Replacing packaging with packvers in src/scripts Jan 10, 2023
pombredanne
pombredanne requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Please add also packvers to https://github.com/nexB/skeleton/blob/main/etc/scripts/requirements.txt

@swastkk
Copy link
Contributor Author

swastkk commented Jan 11, 2023

Thank you! Please add also packvers to https://github.com/nexB/skeleton/blob/main/etc/scripts/requirements.txt

Done ✔️

@swastkk swastkk requested a review from pombredanne January 11, 2023 20:02
pombredanne
pombredanne approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging! Thanks!

@pombredanne pombredanne changed the title Replacing packaging with packvers in src/scripts Replace packaging with packvers in src/scripts Jan 12, 2023
pombredanne
pombredanne requested changes Jan 12, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, one last change if you do not mind:
Can you squash and update your commit message?
Thanks!

@swastkk
Replace packaging with packvers
1bd7a2f 
* import update in src/scripts/utils_dejacode

* Packvers replacing packaging in other src/scripts

* Added packvers in src/scripts/requirments.txt

Signed-off-by: swastik <[email protected]>
@swastkk swastkk requested a review from pombredanne January 12, 2023 16:09
@swastkk
Copy link
Contributor Author

swastkk commented Jan 12, 2023

Actually, one last change if you do not mind: Can you squash and update your commit message? Thanks!

okay now?

pombredanne
pombredanne approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
we want to have one empty line after the subject line for next time. I am merging now.

@pombredanne pombredanne merged commit 5be2690 into aboutcode-org:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace packaging with packvers
2 participants
@swastkk @pombredanne