-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve xgettext handlings #16
Conversation
Reference: #13 Reference: #14 Reported-by: Armijn Hemel @armijnhemel Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #11 Reported-by: Armijn Hemel @armijnhemel Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #14 Reported-by: Armijn Hemel @armijnhemel Signed-off-by: Philippe Ombredanne <[email protected]>
@keshav-space can you help me there?
|
Ack, will add the necessary change in this PR. |
Signed-off-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Keshav Priyadarshi <[email protected]>
48914f0
to
f3a9351
Compare
Signed-off-by: Keshav Priyadarshi <[email protected]>
f3a9351
to
9b74543
Compare
So what about file names that have a space in it, or perhaps have a semicolon? Those are valid file names and
I am not sure how common file names with semicolons are, but file names with spaces are not uncommon. As far as I can tell
|
thinking a bit more: the only certainty that you have is that the part after the last |
This PR addresses these issues:
@armijnhemel FYI since you reported these!