Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for MacOS 10.14 #436

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Build for MacOS 10.14 #436

wants to merge 4 commits into from

Conversation

ahmad88me
Copy link

@ahmad88me ahmad88me commented Sep 11, 2024

This PR addresses the issue: #434

Key Changes:

  • The project now successfully builds on macOS 10.14.
  • Note: While the code builds on macOS 10.14, the SignInWithApple functionality still requires macOS 10.15 due to Apple's platform restrictions.

Why is this change important?

Previously, even if the SignInWithAppleButton was only required for iOS, the build would still fail on macOS 10.14 due to missing APIs introduced in macOS 10.15. This meant that any project targeting macOS 10.14, even if only for non-sign-in functionality, would encounter build errors.

Purpose:

This change allows developers to conditionally include SignInWithAppleButton for iOS without breaking the build on macOS 10.14. For example, this code pattern will now work as expected:

if (Platform.isIOS) {
  SignInWithAppleButton(...)
}

By making the build compatible with macOS 10.14, we ensure that developers who don’t need macOS-specific sign-in functionality can still compile their apps, while the sign-in feature remains available for macOS 10.15 and above.

Testing:

I have tested this on macOS 10.14. Further testing on macOS 10.15 and higher is recommended to confirm that the SignInWithApple functionality works as expected on those versions.

@tp
Copy link
Collaborator

tp commented Sep 19, 2024

Thanks! This looks good, but since you're the only one ever asking for this in all the years we've had this plugin, I am not sure it'd be smart to merge this right now.

Especially since no-one of the other core contributors has access to an old macOS machine to keep ensuring compatibility (and further GitHub actions don't offer them anymore either, so we could not even compile it in CI as a minimal sanity check).

So for now I would appreciate if you just keep up the fork for anyone interested.

If we need a major update in the future (for whatever changes might come), we might want to re-evaluate. (Though maybe on the flip-side Flutter itself might've dropped support for this version in their then latest release…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants