Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI housekeeping #1350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CI housekeeping #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/elixir.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: CI

on:
push:
pull_request:
branches:
- main
pull_request:
Comment on lines -5 to +7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the duplicate check from 26 to 13 by limiting it to pull request branch branch only instead of adding main branch as well.


jobs:
test:
Expand All @@ -17,21 +17,21 @@ jobs:
- '1.15'
- '1.16'
- '1.17'
- '1.18'
otp:
- '25'
- '26'
- '27'
# see https://hexdocs.pm/elixir/compatibility-and-deprecations.html#between-elixir-and-erlang-otp
exclude:
- otp: 25
elixir: 1.17
- otp: 27
elixir: 1.15
- otp: 27
elixir: 1.16
- elixir: 1.16
otp: 27
- elixir: 1.15
otp: 27

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up Elixir
uses: erlef/setup-beam@v1
Expand All @@ -40,7 +40,7 @@ jobs:
otp-version: ${{ matrix.otp }}

- name: Restore deps cache
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: |
deps
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
SCHEMA_PROVIDER: persistent_term

- name: Cache/uncache PLTs
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
priv/plts
Expand Down
2 changes: 1 addition & 1 deletion lib/absinthe/utils/render.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ defmodule Absinthe.Utils.Render do
end

defp escape_string(<<char::utf8, rest::binary>>, acc) do
escape_string(rest, [acc | <<char::utf8>>])
escape_string(rest, acc ++ [<<char::utf8>>])
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the following error with mix dialyzer on Elixir 1.18:

lib/absinthe/utils/render.ex:51:5:improper_list_constr
List construction (cons) will produce an improper list, because its second argument is bitstring().
________________________________________________________________________________
done (warnings were emitted)
Halting VM with exit status 2


defp escape_string(<<>>, acc) do
Expand Down