Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE-Add service filter #22

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

felixgateru
Copy link
Contributor

What does this do?

Add service filter to callhome sdk

Which issue(s) does this PR fix/relate to?

Resolves ultravioletrs/issues#271

List any changes that modify/break current functionality

None

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

@drasko
Copy link
Contributor

drasko commented Aug 2, 2023

@SammyOina this one also, please

@ianmuchyri
Copy link

@1998-felix Some of the commits in this PR have already been merged: Add city filter and Fix missing country in OpenAPI. Also, Add version filter is a commit in another PR #21

@SammyOina
Copy link
Contributor

SammyOina commented Aug 3, 2023

To be merged after #21, also @1998-felix please rebase, to remove merged commits

Copy link
Contributor

@SammyOina SammyOina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be ok to merge after rebase and should be merged after #21

Signed-off-by: felixgateru <[email protected]>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 1a73c9a into absmach:main Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants